Classbased patterns #1109
Merged
Classbased patterns #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for better customization in deriving projects.
Make sure that submit events are canceled on invalid forms by using a
capturing event handler which is invoked before non-capturing events.
The previous commit exposed a problem with the submit event handling,
where the then non-capturing submit event handler was registered
later than the one from pat-inject because pat-validation's async
init method where pat-inject's init method is yet non-async. That
happened even the pat-validation's pattern initialization is
enforced to run first due to registration reordering in the Pattern
registry. Now with the capturing event handler this problem is
fixed.
thet
force-pushed
the
classbased-patterns
branch
from
f69883c to
e218af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.