pat-scroll: Implement selector:top
#722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #721
Note:
IIRC, The original issue appeared when injecting content into a site where we want to scroll to the top of the page and not keep the old scroll position.
This problem is actually widely known - e.g. vue-router has a special
scrollBehavior
option for route-changes for this: https://router.vuejs.org/guide/advanced/scroll-behavior.htmlAn alternative solution would be to implement the scrolling behavior in pat-inject after the injection was done.
@cornae @pilz