Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat-inject: default selector #724

Merged
merged 3 commits into from
May 21, 2020
Merged

pat-inject: default selector #724

merged 3 commits into from
May 21, 2020

Conversation

thet
Copy link
Member

@thet thet commented May 21, 2020

  • pat-inject: Rename undocumented selector property to defaultSelector.
  • pat-inject: Fix typo in docs for the source property.

@thet thet requested a review from pilz May 21, 2020 14:14
@thet thet mentioned this pull request May 21, 2020
@thet thet force-pushed the thet-injectdefaultSelector branch from 986a1d4 to 7176111 Compare May 21, 2020 14:23
@cornae
Copy link
Member

cornae commented May 21, 2020

Hi @thet, what does default selector do exactly? 'self'? And then if you use it would it select another element as the section trigger?

The property should be named default-selector as, similar to CSS, Patterns never uses camel case for its properties.

@thet thet force-pushed the thet-injectdefaultSelector branch from 7176111 to db72569 Compare May 21, 2020 15:25
@thet
Copy link
Member Author

thet commented May 21, 2020

@cornae thanks for the review! I have changed it to default-selector.
If there is a #IDSELECTOR part in the url property or the href attribute, then this is used as default selector. If not, body is used. This default selector is only useed when no source or target are defined.

@pilz pilz merged commit e33365f into master May 21, 2020
@pilz pilz deleted the thet-injectdefaultSelector branch May 21, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants