-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Overwrite resolver version for Haskell solutions #13
Comments
Hi @Javran, thanks for the suggestion! A small doubt though: aren't such configuration options the whole point for reproducible builds? To me, it ensures that everything works correctly, as it should, especially for dependencies but also for the compiler itself it seems in Haskell. Are you sure that overwriting this automatically would never break anything? Also, how heavy is a resolver download? I would say less than five megabytes would not be worth the trouble. If you still wish the feature to be added, then I would appreciate a PR: I don't really master every track environment, so testing the solution yourself would be preferable. Also, is there any configuration value for |
I'm 99% sure overwriting While changing resolver isn't always expensive, changing resolver when there is a ghc version change is - my While it's possible to determine latest LTS version, exercism/haskell does use a fixed version of LTS, but there isn't a good way to find that version, in either case, I'd prefer just leaving this as an option to the user rather than complicating Edit: forget to mention, feel free to assign me to this bug, I'm happy to take a look. |
Alright, I understand the situation then, thanks for the explanation. You can start working on it 😉 |
Closes PaulDance#13. This patch also bundled some other changes: - `-Wall` to `--ghc-options -Wall` as this is supposed to be pased to GHC (stack can't recognize this flag) - Removed `--trace` as it tends to be verbose and messes up hspec's output.
Closes PaulDance#13. This patch also bundled some other changes: - `-Wall` to `--ghc-options -Wall` as this is supposed to be pased to GHC (stack can't recognize this flag) - Removed `--trace` as it tends to be verbose and messes up hspec's output.
The current issue when reviewing an old solution is that the resolver is set to a very old version, which would download a different old version of compiler together with some outdated packages, all need to be compiled, so to avoid that I ended up just editing
stack.yaml
as the first step for running tests.I suggest adding an environment variable, say
EXERCISM_HASKELL_STACK_RESOLVER=lts-16.21
,when this value is set to non-empty values, solution's
stack.yaml
's content will be overwritten toresolver: $EXERCISM_HASKELL_STACK_RESOLVER
The text was updated successfully, but these errors were encountered: