Skip to content

Commit

Permalink
Revert Asset to Dataset for Core Extension Doc (apache#42867)
Browse files Browse the repository at this point in the history
This PR reverts Core Extension doc change (https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html) from apache#41348

Since those docs only work on Airflow stable, we can only change this after 3.0
  • Loading branch information
kaxil authored and PaulKobow7536 committed Oct 24, 2024
1 parent 4d4a6af commit 65fa10c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
11 changes: 7 additions & 4 deletions docs/apache-airflow-providers/core-extensions/asset-schemes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,17 @@
specific language governing permissions and limitations
under the License.
asset URI Schemes
Dataset URI Schemes
-------------------

This is a summary of all Apache Airflow Community provided implementations of asset URI schemes
This is a summary of all Apache Airflow Community provided implementations of dataset URI schemes
exposed via Airflow core and community-managed providers.

See :doc:`documentation on assets <apache-airflow:authoring-and-scheduling/assets>` for details on how asset URIs work.
..
TODO: Change this from Dataset to Asset in Airflow 3.0
.. airflow-asset-schemes::
See :doc:`documentation on Datasets <apache-airflow:authoring-and-scheduling/datasets>` for details on how dataset URIs work.

.. airflow-dataset-schemes::
:tags: None
:header-separator: "
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ Exposing customized functionality to the Airflow's core:
* ``filesystems`` - this field should contain the list of all the filesystem module names.
See :doc:`apache-airflow:core-concepts/objectstorage` for description of the filesystems.

* ``asset-uris`` - this field should contain the list of the URI schemes together with
..
TODO: Change this from Dataset to Asset in Airflow 3.0
* ``dataset-uris`` - this field should contain the list of the URI schemes together with
class names implementing normalization functions.
See :doc:`apache-airflow:authoring-and-scheduling/assets` for description of the asset URIs.
See :doc:`apache-airflow:authoring-and-scheduling/datasets` for description of the dataset URIs.

.. note:: Deprecated values

Expand Down
2 changes: 1 addition & 1 deletion docs/exts/operators_and_hooks_ref.py
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ def setup(app):
app.add_directive("airflow-executors", ExecutorsDirective)
app.add_directive("airflow-deferrable-operators", DeferrableOperatorDirective)
app.add_directive("airflow-deprecations", DeprecationsDirective)
app.add_directive("airflow-asset-schemes", DatasetSchemeDirective)
app.add_directive("airflow-dataset-schemes", DatasetSchemeDirective)

return {"parallel_read_safe": True, "parallel_write_safe": True}

Expand Down

0 comments on commit 65fa10c

Please sign in to comment.