Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMSTileLayer doesn't initialise zIndex or opacity #404

Closed
7 tasks done
markhepburn opened this issue Oct 30, 2017 · 3 comments
Closed
7 tasks done

WMSTileLayer doesn't initialise zIndex or opacity #404

markhepburn opened this issue Oct 30, 2017 · 3 comments

Comments

@markhepburn
Copy link
Contributor

Before opening an issue, make sure to read the contributing guide and understand this is a bug tracker, not a support platform.

Please make sure to check the following boxes before submitting an issue.
Issues opened without using this template will be closed unless they have a good reason not to follow this template.

  • All peer dependencies are installed: React, ReactDOM and Leaflet.
  • Using a supported version of React and ReactDOM (v15.x or v16.x).
  • Using the supported version of Leaflet (v1.2.x) and its corresponding CSS file is loaded.
  • Using the latest stable version of React-Leaflet.
  • The issue has not already been reported.
  • Make sure you have followed the quick start guide for Leaflet.
  • Make sure you have fully read the documentation and that you understand the technical considerations.

Expected behavior

Should be able to initialise the zIndex and opacity properties on a WMS layer.

Actual behavior

Those properties are removed at initialisation time so not set on the initial element.

(Changes to both are still applied correctly, via updateLeafletElement)

Steps to reproduce

WebpackBin.
@markhepburn
Copy link
Contributor Author

PR incoming.

(First thing I noticed was "404" in the URL and thought "crap, has my ticket just been lost?" :))

markhepburn added a commit to markhepburn/react-leaflet that referenced this issue Oct 30, 2017
@markhepburn
Don't remove zIndex/opacity from initial WMS props
7c3d0e7 
See PaulLeCam#404.  Initial values were being removed
from the parameters passed to the leaflet element when it was first
created; later updates were still correctly applied.
@markhepburn markhepburn mentioned this issue Oct 30, 2017
Merged
PaulLeCam pushed a commit that referenced this issue Oct 31, 2017
@markhepburn @PaulLeCam
Don't remove zIndex/opacity from initial WMS props (#405)
638fafc 
See #404.  Initial values were being removed
from the parameters passed to the leaflet element when it was first
created; later updates were still correctly applied.
@PaulLeCam
Copy link
Owner

Should be fixed in v1.7.2 now thanks to your PR, please try it out.

@markhepburn
Copy link
Contributor Author

Looks great, thanks.

roberttstanley added a commit to roberttstanley/react-leaflet that referenced this issue Jun 30, 2022
@roberttstanley
Don't remove zIndex/opacity from initial WMS props (#405)
d98b3d9 
See PaulLeCam/react-leaflet#404.  Initial values were being removed
from the parameters passed to the leaflet element when it was first
created; later updates were still correctly applied.
riseeverytime pushed a commit to riseeverytime/leaflet that referenced this issue Feb 5, 2023
@markhepburn @riseeverytime
Don't remove zIndex/opacity from initial WMS props (#405)
bc691a9 
See PaulLeCam/react-leaflet#404.  Initial values were being removed
from the parameters passed to the leaflet element when it was first
created; later updates were still correctly applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markhepburn @PaulLeCam