Add dynamic draggable props to Marker #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea, thanks! |
|
Published in v0.11.3. |
PaulLeCam
pushed a commit
that referenced
this pull request
May 4, 2016
* Set source argument in Popup creation
* v0.10.1
* Animate panning and zooming
* v0.10.2
* Lint 'object destructuring filter' consistently
The pattern ```const { map, url, ...props } = this.props``` usually
failed during linting, because the ```map``` variable is defined but
not used.
After adding the ```"varsIgnorePattern": "^_"``` option to the
```no-unused-vars``` rule, unused properies can be marked as:
```const { map: _, url, ...props } = this.props```.
I also updated the eslint and babel-eslint dependencies, because of
some relevant bugfixes.
* Add babel-plugin-lodash
* Introduce the concept of 'layer container', as a unified interface for L.Map and L.LayerGroup.
* v0.11 - new LayersControl
* Component-based LayersControl
* Deprecate `onLeaflet...` format for events
* React v15
* LayersControl does not pass map props to children (#142)
* v0.11.1
* v0.11.2
* Add dynamic draggable props to Marker (#148)
* expose ability to toggle marker's draggable status
* fix indentation
* v0.11.3
PaulLeCam
pushed a commit
that referenced
this pull request
May 5, 2016
* Set source argument in Popup creation
* v0.10.1
* Animate panning and zooming
* v0.10.2
* Lint 'object destructuring filter' consistently
The pattern ```const { map, url, ...props } = this.props``` usually
failed during linting, because the ```map``` variable is defined but
not used.
After adding the ```"varsIgnorePattern": "^_"``` option to the
```no-unused-vars``` rule, unused properies can be marked as:
```const { map: _, url, ...props } = this.props```.
I also updated the eslint and babel-eslint dependencies, because of
some relevant bugfixes.
* Add babel-plugin-lodash
* Introduce the concept of 'layer container', as a unified interface for L.Map and L.LayerGroup.
* v0.11 - new LayersControl
* Component-based LayersControl
* Deprecate `onLeaflet...` format for events
* React v15
* LayersControl does not pass map props to children (#142)
* v0.11.1
* v0.11.2
* Add dynamic draggable props to Marker (#148)
* expose ability to toggle marker's draggable status
* fix indentation
* v0.11.3
* Changes removeFrom to remove in MapControl
* Removes MultiPolyline; multipolylines are now supported by Polyline
* Removes MultiPolygon; multipolygons are now supported by Polygon
* Removes CanvasTileLayer, which has been removed from leaflet
* Updates Circle instantiator to use new format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggling draggable status is a useful part of leaflet markers, it is nice to have it exposed via props on the Marker component. Usage example included.