Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "flyTo" #192

Merged
merged 6 commits into from
Jul 25, 2016
Merged

Support "flyTo" #192

merged 6 commits into from
Jul 25, 2016

Conversation

jgimbel
Copy link
Contributor

@jgimbel jgimbel commented Jul 23, 2016

proposed solution to #183

@PaulLeCam
Copy link
Owner

Thanks!
Could you please remove the code related to generating an id for the map? It should not be needed anymore as the L.map() factory accepts a DOMElement in Leaflet v1.

@jgimbel
Copy link
Contributor Author

jgimbel commented Jul 24, 2016 •
edited
Loading

Yep. I tried without and it didn't pass the server side render test. Let me double check that I have leaflet v1 and see if that fixes it after the change.

@jgimbel
Copy link
Contributor Author

jgimbel commented Jul 24, 2016

Please have a look at the Travic CI output. Should the test be updated? It would seem that v1 does not add its own map id in v1 (source and related source).

@PaulLeCam
Copy link
Owner

Oh yes sorry I forgot to push an update to the test, should be OK now.

@jgimbel jgimbel closed this Jul 24, 2016
@jgimbel jgimbel reopened this Jul 24, 2016
@PaulLeCam PaulLeCam merged commit 29123c8 into PaulLeCam:leaflet-1.0 Jul 25, 2016
@PaulLeCam
Copy link
Owner

Thanks!

@jgimbel jgimbel deleted the flyto branch July 25, 2016 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgimbel @PaulLeCam