Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to satisfy flow 59 #412

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Add types to satisfy flow 59 #412

merged 1 commit into from
Nov 10, 2017

Conversation

rsolomon
Copy link
Contributor

@rsolomon rsolomon commented Nov 9, 2017

Upgrading to flow-bin@0.59.0 yields the following errors:

$ flow
Error: src/LayersControl.js:105
105:   addLayer(layer) {
                ^^^^^ parameter `layer`. Missing annotation

Error: src/LayersControl.js:115
115:   addLayer(layer) {
                ^^^^^ parameter `layer`. Missing annotation

This commit adds some missing annotations, satisfying the beast.

@PaulLeCam PaulLeCam merged commit d3e5fd3 into PaulLeCam:master Nov 10, 2017
@PaulLeCam
Copy link
Owner

Thanks!

@rsolomon
Copy link
Contributor Author

No problem. Any chance this could make it into a release?

@PaulLeCam
Copy link
Owner

Yes it's done now in v1.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsolomon @PaulLeCam