Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Popup element only after render is complete #423

Merged
merged 1 commit into from
Dec 3, 2017
Merged

Update Popup element only after render is complete #423

merged 1 commit into from
Dec 3, 2017

Conversation

jeffchan
Copy link
Contributor

@jeffchan jeffchan commented Dec 2, 2017

Fixes #422

Test plan:

Manual :(

Since we mock out Leaflet.Popup I was unable to write a test case. Open to suggestions!

@PaulLeCam PaulLeCam merged commit ac46346 into PaulLeCam:master Dec 3, 2017
@PaulLeCam
Copy link
Owner

Good catch, thanks!

@jeffchan jeffchan deleted the fix-react-16 branch December 3, 2017 01:00
@jeffchan
Copy link
Contributor Author

jeffchan commented Dec 3, 2017

No problem. Appreciate the quick review, and thanks for your great work.

@PaulLeCam
Copy link
Owner

Thanks! It's now pushed in v1.7.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffchan @PaulLeCam