Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sinus and cosinus for SD59x18 #230

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented May 9, 2024

(work in progress)

@Amxx Amxx force-pushed the feature/cos-sin branch from 84b0de8 to eb9b811 Compare May 9, 2024 16:30
@Amxx
Copy link
Contributor Author

Amxx commented May 9, 2024

Note: https://github.com/mds1/solidity-trigonometry/blob/main/src/Trigonometry.sol should be considered. I don't understand the underlying logic, but if translated to signed integers, it might be cheaper / more accurate ?

@PaulRBerg
Copy link
Owner

Hi @Amxx, thank you for your PR. I just wanted to say that it might take a few weeks (or more) until I'm able to review this.

The lint job appears to be failing. Have you run forge fmt locally? Using VSCode should automatically do this for you.

@Amxx
Copy link
Contributor Author

Amxx commented May 20, 2024

@PaulRBerg Sure, not rush. There may be otehr implementations that deserves exploring anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants