Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use return instead of param for return parameter documentation #241

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ericglau
Copy link
Contributor

Some functions document the return parameter using the @param NatSpec tag, and the Solidity compiler does not fail in these cases. However, since these are referring to return parameters instead of function parameters, it would be more correct to document them as @return instead.

@PaulRBerg
Copy link
Owner

Good catch! Thanks for the PR.

Do you need a new version shipped to the npm registry or can you install from GitHub directly?

@PaulRBerg PaulRBerg added the type: docs Changes to documentation. label Jul 22, 2024
Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@ericglau
Copy link
Contributor Author

Thanks @PaulRBerg. I don't need a new version, this is just a suggested improvement for the NatSpec tags.

@PaulRBerg PaulRBerg merged commit 7fe04e7 into PaulRBerg:main Jul 22, 2024
3 checks passed
@ericglau ericglau deleted the returndocs branch July 22, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants