Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Security Section #242

Closed
wants to merge 6 commits into from
Closed

Conversation

CanonicalJP
Copy link
Contributor

Description

Added reference to security reviews of the codebase

Changes

  • Modified README.md
  • Added audits/AUDITS.md

Related Issue

Related to #197

Created draft version with details of Cantina's review
Added the details about the security bug made by Certora and refactored the text
@CanonicalJP
Copy link
Contributor Author

Ready for your review @PaulRBerg

Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0xJayPi, thanks for your PR. I have reviewed it now and I want to make some changes, but it looks like I am not allowed to do that:

! [rejected] main -> main (non-fast-forward)

Could you please give me permission to push to your branch?

Alternatively, please make your changes on a new branch (not on main). That will make it work.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard place to place security-related information is the SECURITY.md file. Let's move this file over there.

@CanonicalJP
Copy link
Contributor Author

Apologies, first time I don't create a branch for simplicity. I'll make the needed changes next week (on vacations leave right now)

@CanonicalJP
Copy link
Contributor Author

@PaulRBerg. I just sent you an invite to my repo. If still needed, I can just move forward and do a new branch and move everything there. Please let me know

@PaulRBerg
Copy link
Owner

@0xJayPi I would prefer not to be added as a collaborator to your repo. Please just create a new PR with a different branch. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants