feat: get proxy #118
Merged
feat: get proxy #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
331ab8c to
5e0ad6b
Compare
PaulRBerg
force-pushed
the
refactor/ownersip-redesign
branch
from
a15da64 to
33c9208
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
3 times, most recently
from
b82eae6 to
036ba4a
Compare
PaulRBerg
changed the base branch from
refactor/ownersip-redesign
to
refactor/ownership-redesign
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
d457088 to
342ca1d
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
2 times, most recently
from
c206840 to
4a52570
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
342ca1d to
f5fa428
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
4a52570 to
c50f980
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
f5fa428 to
8e42354
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
c50f980 to
7c60ec5
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
8e42354 to
9750486
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
7c60ec5 to
c026f78
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
9750486 to
c738a35
Compare
andreivladbrg
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
I think you missed this:
prb-proxy/src/PRBProxyRegistry.sol
Line 136 in c026f78
User facing functions?
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
c026f78 to
61ec3ea
Compare
|
Good catch!! Resolved. |
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
61ec3ea to
f55cba6
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
c738a35 to
b9144a7
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
f55cba6 to
397ab88
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
2 times, most recently
from
b229563 to
17f65af
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
397ab88 to
ea80da3
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
af7353c to
e060114
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
ea80da3 to
3c7f207
Compare
PaulRBerg
force-pushed
the
refactor/ownership-redesign
branch
from
e060114 to
07fed42
Compare
refactor: make proxies mapping internal
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
3c7f207 to
3ee2fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116.