refactor: storage redesign #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
feat/get-proxy
branch
2 times, most recently
from
61ec3ea to
f55cba6
Compare
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
from
e366797 to
6cbe0d6
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
f55cba6 to
397ab88
Compare
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
2 times, most recently
from
34a7a83 to
f58060c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+212
to
+235
| function uninstallPlugin(IPRBProxyPlugin plugin) external override onlyCallerWithProxy { | ||
| // Get the method list to uninstall. | ||
| bytes4[] memory methodList = plugin.methodList(); | ||
|
|
||
| // The plugin must have at least one listed method. | ||
| uint256 length = methodList.length; | ||
| if (length == 0) { | ||
| revert PRBProxyRegistry_PluginEmptyMethodList(plugin); | ||
| } | ||
|
|
||
| // Uninstall every method in the list. | ||
| address owner = msg.sender; | ||
| for (uint256 i = 0; i < length;) { | ||
| delete _plugins[owner][methodList[i]]; | ||
| unchecked { | ||
| i += 1; | ||
| } | ||
| } | ||
|
|
||
| // Log the plugin uninstallation. | ||
| emit UninstallPlugin(owner, _proxies[owner], plugin); | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities
Comment on lines
+181
to
+204
| function installPlugin(IPRBProxyPlugin plugin) external override onlyCallerWithProxy { | ||
| // Get the method list to install. | ||
| bytes4[] memory methodList = plugin.methodList(); | ||
|
|
||
| // The plugin must have at least one listed method. | ||
| uint256 length = methodList.length; | ||
| if (length == 0) { | ||
| revert PRBProxyRegistry_PluginEmptyMethodList(plugin); | ||
| } | ||
|
|
||
| // Install every method in the list. | ||
| address owner = msg.sender; | ||
| for (uint256 i = 0; i < length;) { | ||
| _plugins[owner][methodList[i]] = plugin; | ||
| unchecked { | ||
| i += 1; | ||
| } | ||
| } | ||
|
|
||
| // Log the plugin installation. | ||
| emit InstallPlugin(owner, _proxies[owner], plugin); | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
from
f58060c to
30a8cd4
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
from
397ab88 to
ea80da3
Compare
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
2 times, most recently
from
b47288b to
c2b3225
Compare
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
from
c2b3225 to
37dc8be
Compare
tibbarytsur
reviewed
Jun 21, 2023
andreivladbrg
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
|
Thanks for the review, both! @andreivladbrg - the |
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
from
7a56a9a to
27479f6
Compare
PaulRBerg
force-pushed
the
feat/get-proxy
branch
2 times, most recently
from
3c7f207 to
3ee2fc3
Compare
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
2 times, most recently
from
a060837 to
3c58593
Compare
feat: add "getPluginByProxy" getter feat: add "getPermissionByProxy" getter perf: optimize "execute" refactor: delete annex refactor: delete 'system' scripts refactor: get rid of proxy storage refactor: rename getters refactor: rename "selector" param to "method" test: fix events and re-enable tests test: update tests in light of new contract API
PaulRBerg
force-pushed
the
refactor/storage-redesign
branch
from
3c58593 to
83b4993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/cantinasec/review-sablier2/issues/13, the problem explained in #100, and PRB-01M: Insufficient Protection Against Hostile Takeover.
Changelog:
pluginsand thepermissionsare now in the registryAnnexcontract anymore