don't set do_zero flag when initializing extmem heap (improve performance when allocating) #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the extmem_smalloc_pool is created, the do_zero flag is set which causes smalloc to always zero out allocated memory. This reduces allocation performance since it's only required by calls to calloc, not malloc.
This patch unsets the do_zero flag, manually clears any statically allocated EXTMEM memory (which wasn't being done before in violation of C spec - uninitialized static data should be zeroed) and makes extmem_calloc() call sm_calloc_pool() instead of sm_malloc_pool().