Fixes #360. Adds support for deep subModelType hierarchies. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursively resolves the appropriate subModelType to instantiate in 'Backbone.RelationalModel.build'. This allows subModelTypes to in turn declare their own subModelTypes.
… current model's hierarchy.
…l.initializeModelHierarchy into it's own method so that initializing super-class relations doesn't cause the super-class's model hierarchy to become initialized. There are situations where initializing the super-class's model hierarchy during relation inheritance will prevent some relations from being inherited. Updated the logic in Backbone.RelationalModel.initializeModelHierarchy that recursively initializes the model hierarchy of subModels so that it doesn't initialize models that have already been initialized.
|
Looks like a great feature! I'll hopefully get around to reviewing it properly this week or beginning of next week. |
PaulUithol
added a commit
that referenced
this pull request
Jul 23, 2013
Fixes #360. Adds support for deep subModelType hierarchies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursively resolve the appropriate subModelType to instantiate in
'Backbone.RelationalModel.build'. This allows subModelTypes to in turn declare
their own subModelTypes.