-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: opReturn feature #469
Conversation
fc47373
to
994c468
Compare
40d052f
to
f15b1d8
Compare
7366a34
to
9c80879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some corrections.
Also: maybe worth it mentioning that the data payload can be at most 213 bytes (when UTF-8 encoded), if there is no paymentId, if there is the limit is 205 bytes (since the paymentId takes 8 bytes.)
docs/README.md
Outdated
|
||
- `0102030405060708090a0b0c` → Data payload | ||
|
||
- `08` → 8-byte value indicating that this transaction has an 8-byte payment ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a "8-byte value", it is the number 8 represented in one byte.
docs/README.md
Outdated
|
||
- `08` → 8-byte value indicating that this transaction has an 8-byte payment ID | ||
|
||
- `0102030405060708` → payment ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uppercase
docs/README.md
Outdated
|
||
- `00` → No data payload | ||
|
||
- `08` → 8-byte value indicating that this transaction has an 8-byte payment ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here
docs/README.md
Outdated
|
||
- `08` → 8-byte value indicating that this transaction has an 8-byte payment ID | ||
|
||
- `0102030405060708` → payment ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here
58656b1
to
a332169
Compare
Related to #429
Description
Added a new topic on docs to describe opReturn syntax rules
Test plan
Run yarn start:docs and go to OpReturn topic