move storage factory init from PayumBundle::build to PayumExtension::load #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lsmith77 Does it work for you? |
|
it fixes the issue I encountered .. but hoping that the travis tests reveal if this creates other issues .. |
|
for ref Sylius/Sylius#8979 (comment) |
lsmith77
force-pushed
the
fix_storage_factory_init
branch
from
08f6924 to
afcd614
Compare
lsmith77
force-pushed
the
fix_storage_factory_init
branch
from
afcd614 to
b94e0d8
Compare
|
ok looks better now .. but didn't really do a manual test to confirm that everything is still working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.