read_web_config upgrades #1675
Merged
read_web_config upgrades #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stitution of output_folder into dbfiles_folder, which is what we need returned for file ingest Shiny
|
@mdietze I'm paired with you this week. |
tonygardella
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_web_configwasn't returning the variable that @LiamBurke24 needs from it,dbfile_folder, because it involved a cross-reference to output_folder, and because it had a previous kluge of only returning the first 14 lines (which was enough to get BETY info but avoided dealing with other parsing challenges)Currently finding and replacing references is a bit of a kluge that would be nice to generalize (will probably fail if there are multiple replacements to make), but it works for the config.php I tested it on.