release 1.5.1 #1712
Merged
release 1.5.1 #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the construction of the model frame, things become ordered differently than we see in the data we feed into this function & reference to pull our appropriate rows. This requires some tweaking, but it looks like it’s working in the end.
In <crollinson@dd35d8cecf796e44c03641c6508c e75ad5abaf86> I’d fixed a bug with how the data was ordered. Changing the order of operations then caused a problem with the swdown case because it was looking at total dimensions rather than just the hours. This should fix both ordering & level issues.
(I always forget to do the commands to update the documentation, so here it is at the end.)
Temporal downscaling workflow updates
Dataone download util
update develop from release/1.5.1
Fixes to download NEON
Switching from `system` to `system2` broke this for advanced commands with pipes in them, because these pipes were quoted by `system2` and therefore interpreted as arguments. This reverts to using `system` for local `qsub` calls, and for remote calls, sends the entire command as a single argument.
Bugfixes in remote code
Update CHANGELOG.md
Merge Release/v1.5.1 into Develop on 9/28/17
Update to check_qsub function so that it waits properly
1. I meant to type "settings no longer depends on utils" 2. But that's not true either. Therefore, revert. This reverts commit 5e28d6f.
These packages are all used by PEcAn.utils *only* in functions that will soon be broken out of PEcAn.utils into a new PEcAn.workflow package. Moving the dependencies to Suggests as an initial step, will move functions in a separate PR.
Note that depending on methods is a workaround for a bug in lubridate (tidyverse/lubridate#499) and we do not use any of its festures directly.
Initial utils cleanup
Because there are were different scripts named utils.R: pecan/base/utils/R/utils.R and pecan/base/db/R/utils.R
Changing the name of the utils.R script in db
tonygardella
approved these changes
Oct 6, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official release of 1.5.1