Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FATES output time variable to fix issue #1939. #1953

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

serbinsh
Copy link
Member

Current fix is to keep the same time time_since from the first year of the run (CLM default). However we could change this so it resets for each year if that is preferred

Review Time Estimate

  • [X ] Immediately
  • Within one week
  • When possible

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • [X ] I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Shawn P. Serbin added 2 commits May 31, 2018 09:25
…rrent fix is to keep the same time time_since from the first year of the run (CLM default). However we could change this so it resets for each year if that is preferred
@serbinsh
Copy link
Member Author

Or should we have time restart for each year of the year loop such that the time since is restarted each year?

@serbinsh serbinsh requested review from mdietze and removed request for mdietze May 31, 2018 14:43
@serbinsh serbinsh self-assigned this May 31, 2018
@serbinsh serbinsh added this to the 1.6.0 milestone May 31, 2018
@serbinsh serbinsh added Type: Bug Type: Enhancement Priority: 02 - Normal Status: Ready Pull request ready for merge, or issue ready to be closed labels May 31, 2018
@serbinsh
Copy link
Member Author

Does anyone mind if I merge this? @mdietze ?

@serbinsh serbinsh merged commit 65b3809 into PecanProject:develop Jun 1, 2018
araiho pushed a commit to araiho/pecan that referenced this pull request Jul 26, 2018
…ates

Updated FATES output time variable to fix issue PecanProject#1939.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 02 - Normal Status: Ready Pull request ready for merge, or issue ready to be closed Type: Bug Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants