Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run align_pft examples. Closes #1978 #2062

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

infotroph
Copy link
Member

Plus minor typo fixes

Description

  • wrapped align_pft examples in \dontrun -- The example is informative to human readers but needs a live bety connection, which may not be available when examples are run at package build time. Fixes Benchmark package checks fail #1978.
  • Added unit test constructed from examples above.
  • Typo fixes in variable names. These are minor-looking but potentially disastrous if I misunderstood -- please check carefully.
  • Stopped excluding Benchmark from Travis package checks. This means Travis now runs make check on all PEcAn packages and completes phase 2 of Timeline for package checks in CI (+ list of current check errors) #1949.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph infotroph requested a review from mccabete August 22, 2018 21:33
@mdietze mdietze merged commit 03bda85 into PecanProject:develop Aug 27, 2018
@infotroph infotroph deleted the 1978-benchmark-examples branch August 31, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark package checks fail
3 participants