Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

met2model.BIOCRO: Close all years of input #2486

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

infotroph
Copy link
Member

Fixes #2485

The lack of @export on close_nc_if_open is intentional -- I think there's a chance but not a certainty that it could be useful to other packages, and it's much easier to export it (probably from a different package) if we need it later than it is to remove an exported function if we change our mind about it.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze mdietze merged commit 02455e5 into PecanProject:develop Nov 27, 2019
@infotroph infotroph deleted the fix-2485 branch November 28, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

met2model.BIOCRO leaks filehandles when processing multiple years
2 participants