Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz cleanup #2526

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Viz cleanup #2526

merged 4 commits into from
Jan 30, 2020

Conversation

infotroph
Copy link
Member

Description

  • Namespace fixes
  • Roxygen tweaks
  • Biggest change: renamed plot.netcdf to plot_netcdf. Technically this is a breaking change, but I believe in practice it's only called from the web workflow and I've updated it to match.

Motivation and Context

I'm clearing out my Git stashes and pushing all the bits of code cleanup that I did while working on other things and then put aside to maintain focus in the original PRs. Expect more like this as the week goes on.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze mdietze merged commit 9728999 into PecanProject:develop Jan 30, 2020
@infotroph infotroph deleted the viz-cleanup branch January 30, 2020 16:30
@robkooper robkooper added this to the 1.8.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants