-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis fixes for R 4.0 #2592
Travis fixes for R 4.0 #2592
Conversation
Travis interprets it correctly for now, but may not in future
(plus spelling+whitespace fix)
No longer needed when not trying to juggle C2D4U
Was thinking this would fix "undocumented datasets" check note, but will need to turn on lazy-loading of package data and not yet ready to commit to that. Saving drafts for future use.
My understanding is because of the way Travis handles PR builds[1], it will not be possible to get a passing build on this before merging. You can see the checks passing, after some manual cache-massaging that will hopefully be a one-time thing, by looking at builds for the [1]: Specifically: PR builds take their cache from the target branch, where none of these changes will be until it's merged. |
##' Defaults to the first sensitivity analysis output given | ||
##' @param col Color of each sensitivity analysis. Equivalent to col parameter of the plot function. | ||
##' @param pch Shape of each sensitivity analysis. Equivalent to pch parameter of the plot function. | ||
##' @param main Plot title. Useful for multi-pft variance decompositions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlebauer this seems like ancient history (the function signature seems to have changed to remove these params in 2012) -- are we losing anything of value deleting these?
Description
scripts/travis/rebuild_pkg_binaries.R
, which was an inefficient workaround for C2D4U mixing its compilation versionsoldrel
before), so we now test on the current release, two old versions, and the unreleased development version of R. Only failures in the released version are counted as breaking the build.make install
when asked.R CMD check
now complains when a package imports more than 20 dependencies. We have two such: data.atmosphere and assim.batch. We should probably listen to these complaints eventually, but for now I've ignored them by adding them to the cached check outputs for these packages.data.R
for future use, fixed check script to keep ignoring for now.uncertainty::plot_variance_decomposition
. Checks complained now because R >= 3.6.3 notices when...
appears in documentation but not code (I assume ignoring it before was a bug).RTM::fortran_data_module
(The check for this is new in 4.0)A point of concern: Many of the issues that break the build in 4.0 never showed up in previous R-devel releases (I went back and checked; devel builds were passing consistently before release), and while testing this most of them still don't break the R-devel build (what will become R 4.1). If these are changes implemented in 4.0 that will be sticking around, I don't understand why they aren't also showing up in devel.
Motivation and Context
Review Time Estimate
Types of changes
Checklist: