Updated load_data.R #1592 #2771
Conversation
removed library functions by appropriately providing namespaces to functions.
|
/document |
|
Thanks @moki1202 ! This looks great! FYI, the checks were failing because your changes call for an update to the automated package documentation (specifically, the However, no need to do that here because we have a GitHub Actions bot that will do it for you! My cryptic comment above activated our documentation bot, which will automatically run |
replaced require(bd) with requireNamespace(bd, quietly = TRUE ) in line 43
added 'bd' in the suggests section of modules/benchmark/DESCRIPTION
added comma after testthat (>= 2.0.0) (line 37) and 'BrownDog' packageName to suggests section.
|
/document |
|
@moki1202 Can you please add Extra credit if you want to bother reordering the existing import declarations so the whole listing is actually alphabetical, but clearly the rest of us haven't done that... 🙈 |
modules/benchmark/R/load_data.R
Outdated
| @@ -44,13 +39,13 @@ load_data <- function(data.path, format, start_year = NA, end_year = NA, site = | |||
| fcn <- match.fun(fcn1) | |||
| } else if (exists(fcn2)) { | |||
| fcn <- match.fun(fcn2) | |||
| } else if (!exists(fcn1) & !exists(fcn2) & require(bd)) { | |||
| } else if (!exists(fcn1) & !exists(fcn2) & requireNamespace(bd, quietly = TRUE)) { | |||
There was a problem hiding this comment.
| } else if (!exists(fcn1) & !exists(fcn2) & requireNamespace(bd, quietly = TRUE)) { | |
| } else if (!exists(fcn1) & !exists(fcn2) & requireNamespace("BrownDog", quietly = TRUE)) { |
| SimilarityMeasures, | ||
| zoo, | ||
| stringr | ||
| stringr, |
There was a problem hiding this comment.
| stringr, | |
| stringr, | |
| tidyselect, |
There was a problem hiding this comment.
@infotroph ill get on this ASAP. also, the pleasure was mine, got to learn so much from you guys. thanks for being patient with me hehe.
There was a problem hiding this comment.
also please suggest any error fix that I can start working on after this.
removed library functions by appropriately providing namespaces to functions.