fixes #2804 | undeclared dependencies in DB package

[moki1202]

No description provided.

[mdietze]

This appears to be just a remove, not a move

You also need to remove the corresponding Rd and run make document to build the new Rd file in the correct location.

[moki1202]

@mdietze this PR is still incomplete. Would complete this in 2 mins.

[moki1202]

/document

[infotroph]

/document

[moki1202]

/document

[mdietze]

 Error: Please fix these and resubmit.
  R check of modules/meta.analysis returned new problems:
  Execution halted
  checking dependencies in R code ... WARNING: Missing or unexported object: 'PEcAn.DB::rename_jags_columns'
  checking DESCRIPTION meta-information ... NOTE: Authors@R field gives persons with no role: Mike Dietze Xiaohui Feng Dan  Wang Carl Davidson Rob Kooper Shawn Serbin Shashank Singh
  checking R code for possible problems ... NOTE: rename_jags_columns: no visible binding for global variable 'stat'
  checking R code for possible problems ... NOTE: rename_jags_columns: no visible binding for global variable 'n'
  checking R code for possible problems ... NOTE: rename_jags_columns: no visible binding for global variable 'trt_id'
  checking R code for possible problems ... NOTE: rename_jags_columns: no visible binding for global variable 'citation_id'

[moki1202]

@mdietze I ran R CMD checks and was unable to replicate these warnings, don't know why...

[mdietze]

@moki1202 unfortunately even if you can't replicate the error locally you still need to push the fixes.

The first error is coming from the reference to PEcAn.DB::PEcAn.DB::rename_jags_columns in the jagify function.

The second should be resolvable by assigning roles to the other authors

The no visible binding errors look like they're coming from the use of transform in PEcAn.DB::rename_jags_columns. I don't know if the tidyverse .data trick will work here; you might need to define these variables as NULL at the top of the function. See this blog for details https://www.r-bloggers.com/2019/08/no-visible-binding-for-global-variable/

[infotroph]

Missing or unexported object: 'PEcAn.DB::rename_jags_columns'

PEcAn.DB::rename_jags_columns -> rename_jags_columns (no :: needed because it's now defined in the same package we call it from)

[moki1202]

understood