-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifted convert.input.R from utils to DB #3026
Conversation
Copying the checklist we discussed in Slack here for easy reference:
|
@@ -0,0 +1,891 @@ | |||
##' Convert between formats, reusing existing files where possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like an existing file that should have been moved via git mv
so as to retain version history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdietze when I try to do it using git mv
it says fatal: not under version control, source=base/utils/R/convert_input.R, destination=base/db/R/convert_input.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanu1605 make sure you use the right case in the paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdietze Rebased to address this -- long story short it was less about mv
vs add/rm
and more that the old filename was retained with new content. Placing the defunct stub in a separate file allowed Git to detect the rename correctly.
2f6c37a
to
09fb64b
Compare
To move
convert.input
fromutils
toDB
This replaces #3009, which accumulated enough conflicts that it was easier to redo the changes in a new branch.