Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ECDH with null length #57

Merged
merged 1 commit into from
Nov 2, 2022
Merged

fix: ECDH with null length #57

merged 1 commit into from
Nov 2, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Nov 1, 2022

This PR fixes the ECDH deriveBits op when null is passed as length. This behaviour is covered by Web Platform Tests.

The global DOM types will get updated as soon as the spec bug around actually passing null as length gets fixed.

microshine
microshine approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@microshine microshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update. All changes look well

@microshine microshine merged commit a356531 into PeculiarVentures:master Nov 2, 2022
@panva
Copy link
Contributor Author

panva commented Nov 2, 2022

@microshine thank you, wasn't the publish workflow from master supposed to succeed?

@microshine
Copy link
Collaborator

@peculiar/webcrypto@1.4.1 has been published

@panva
Copy link
Contributor Author

panva commented Nov 2, 2022

Thank you,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microshine microshine microshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panva @microshine