Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positive Status Feedback #33

Closed
Syquel opened this issue Oct 19, 2014 · 13 comments
Closed

Positive Status Feedback #33

Syquel opened this issue Oct 19, 2014 · 13 comments

Comments

@Syquel
Copy link
Contributor

Syquel commented Oct 19, 2014

Hi,

I checked out your latest RC branch and there were some minor things bugging me: A GUI shoud be designed to give either positive or negative feedback by default, but not both. In your case you set the "enabled" status to green, while "Cache full", "Restart pending" and "Restart in progress" appear red. This is quite irritating, because "red" tells me something is wrong.

Therefore you should consider:

  • renaming "Cache full" to "Cache" (if it is full display red, otherwise green or maybe also yellow)
  • combining "Restart pending" and "Restart in progress" to "Status" or "Active" (by default green, restarting / restart pending -> yellow, disabled -> red)
@PeeHaa
Copy link
Owner

PeeHaa commented Oct 19, 2014

@markushausammann also kinda said the same thing some while ago. Which I was about to think about for the new design.

@mr-alien any comments?

@Syquel
Copy link
Contributor Author

Syquel commented Oct 19, 2014

Ah sorry, Of course I should have searched first :/

Also I would propose a "less intrusive" design:
proposal_opcache

Diff:
144 background-color: #e74c3c;
144 background-color: #34495e;

172 background-color: #db3e30;
172 background-color: #2c3e50;

182 color: #770900;
182 /color: #770900;/

186 color: #96251b;
186 /color: #96251b;/

371 color: #E74C3C;
371 color: #3498db;

374 font-weight: 400;
374 font-weight: bold;

478 background: #E74C3C;
478 background: #7f8c8d;

512 background-color: #2ECC71;
512 background-color: #27ae60;

@markushausammann
Copy link

The color coding is still confusing and ambiguous in this screenshot, right?

@ffflabs
Copy link

ffflabs commented Oct 19, 2014

I'm also in favour of the bluish - gray palette instead of the red one. Perhaps it's the right moment to introduce theming.

@Syquel
Copy link
Contributor Author

Syquel commented Oct 19, 2014

Sorry, this was just a screenshot for a proposal of a new color design.
But here you go:
proposal_opcache_2

@markushausammann
Copy link

Nice!

@Syquel
Copy link
Contributor Author

Syquel commented Oct 20, 2014

I jut noticed something else: In the tab "Graphs", the "Hit"-Diagram shows (in my opinion) inverted colors: Hits should be displayed green and misses red. Currently it is quite confusing because it looks like something doesn't go well (The whole diagram is red in my case).

@mr-alien
Copy link
Collaborator

Thank you all for discussing the good and bad parts of the new front end. So I'll reply to your questions/suggestions in parts...

Status Block

  • Cache Full
  • Restart Pending
  • Restart in Progress

Here we have Red and Green blocks according to the status and not according to their functionality. Hence, if they are green, it's like YES, and if they are RED its NO because all three have different meanings but they are booleans in nature.

My recommendation to this is that instead of having color blocks, we can use the words Yes or No which will be rather more clear compared to color blocks.


About the proposed theme

Instead of having a particular theme like Red, Blue and so on, we can introduce some basic color themes as we will be discussing about that #34. I've designed this theme as flat one, so I'll appreciate if users contribute some similar and subtle color schemes(hex) which we can implement on a later stage.


About Graphs

Again, colors are used just to match the theme and not according to their functionality. If we keep swapping colors according to the functionality then there will be inconsistency amongst different pages which I think would be bad as far as the front end consistency goes. If the red is taking too much of the donut part then we can swap that with the third color that is darker flat green.

@markushausammann
Copy link

I really don't think any time should be wasted on elaborate multiple themes. One simple theme that lets the user immediately see what's up with his cache is enough. This is a page I look at maybe once a month or when optimizations are needed. What I find far more important is to make use of the strong affordance of red and green. The faster I understand if anything is wrong, the better. All green, ciao. Something red, need to act.

@mr-alien
Copy link
Collaborator

@markushausammann After commenting, I thought that introducing multiple themes will not only be a waste of time but also will result in multiple opcache identity which is not good.

I got what you are trying to say, so I'll be focusing on the Status page and Charts page, where I'll modify the colors according to their functionalities, then it will be :-

  • Green - Everything's fine
  • Red - You need to check

About the overall theme, I'll think to make it grey or something similar which is not heavy on eyes.

@markushausammann
Copy link

@mr-alien glad you agree, thanks for the work!

@mr-alien
Copy link
Collaborator

@markushausammann thanks for your suggestions and for appreciating my work.

PeeHaa added a commit that referenced this issue Dec 3, 2014
@PeeHaa
Copy link
Owner

PeeHaa commented Dec 3, 2014

The latest release addresses most points raised in this issue.

@PeeHaa PeeHaa closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants