CH Sorting Key: Introduce sorting key expression #2215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heavycrystal
reviewed
Nov 4, 2024
| @@ -233,7 +233,11 @@ func getOrderedOrderByColumns( | |||
|
|
|||
| orderbyColumns := make([]string, len(orderby)) | |||
| for idx, col := range orderby { | |||
| orderbyColumns[idx] = getColName(colNameMap, col.SourceName) | |||
| sortingKeyName := col.SourceName | |||
| if col.SortingKeyExpression != nil && *col.SortingKeyExpression != "" { | |||
There was a problem hiding this comment.
checking for both defeats the purpose of an optional string
either switch to just string or ensure you don't send empty string from upstream
There was a problem hiding this comment.
I prefer not using optional
serprex
reviewed
Nov 4, 2024
| orderbyColumns[idx] = getColName(colNameMap, col.SourceName) | ||
| sortingKeyName := col.SourceName | ||
| if col.SortingKeyExpression != nil && *col.SortingKeyExpression != "" { | ||
| sortingKeyName = *col.SortingKeyExpression |
There was a problem hiding this comment.
lack of validation means this opens up using ; to run an arbitrary query. Hard to say what our threat model is, but we should explicitly get the okay that our threat model assumes anyone with access to ui has access to run arbitrary queries with any clickhouse peer
|
Closing for now as requires more consideration than initially estimated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the backend to support specifying sorting keys such as
function(column)Ex: toDate(updated_at)