refactor starting/stopping ProviderThreads #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How was this tested? |
ianopolous
reviewed
Sep 26, 2023
| private Thread worker; | ||
| private long interval; | ||
| private AtomicBoolean running = new AtomicBoolean(false); | ||
| private AtomicBoolean stopped = new AtomicBoolean(true); |
ianopolous
reviewed
Sep 26, 2023
| public void stop() { | ||
| running.set(false); | ||
| public boolean isRunning() { | ||
| return running.get(); |
There was a problem hiding this comment.
do we need running var in this class now?
ianopolous
reviewed
Sep 26, 2023
| private final Host us; | ||
| private final Kademlia dht; | ||
| private final Queue<Cid> newBlocksToPublish; | ||
|
|
||
| private final ControlSubThread cidProvider; | ||
|
|
||
| private final ControlSubThread newCidProvider; |
There was a problem hiding this comment.
Is there a way to put a generic type on these to make it easier to tell what it is doing from the type, like before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.