add retry to notablock request #430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianopolous
reviewed
Nov 16, 2022
src/components/App.vue
Outdated
| if (domainOpt.isPresent()) { | ||
| let domain = domainOpt.get(); | ||
| that.sendNotABlockRequest(domain, (errCb1) => { | ||
| that.sendNotABlockRequest(domain, (errCb2) => { |
There was a problem hiding this comment.
We should only retry if a http 503 was returned.
There was a problem hiding this comment.
have added code to detect. needs to be deployed to test env to confirm behaviour
There was a problem hiding this comment.
Can we also use recursion rather than 3 nested calls? Just have an extra parameter remainingAttempts?
kevodwyer
force-pushed
the
fix/not-a-block-check
branch
from
fbf2a95 to
36f6fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.