This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2354] Handle metrics request closing before response is generated #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Mar 4, 2019
| @@ -205,7 +205,10 @@ private void metricsRequest(final RoutingContext routingContext) { | |||
| false, | |||
| (res) -> { | |||
| if (res.failed()) { | |||
| LOG.debug("Request for metrics failed", res.cause()); | |||
There was a problem hiding this comment.
Should this be a warn or error?
There was a problem hiding this comment.
Normally I wouldn't make it an error since the error is reported back out to the user already but actually in this case there's no user input to the request so any failures are almost certainly caused by our code being broken. I've increased it to error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Log the reason a metric request failed and check if the result has been closed before writing to it to avoid printing spurious errors to the console.