This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1578] EIP-1052 EXTCODEHASH Operation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he tests from the EIP but tests around self destructing or creating accounts in the same transaction are not yet implemented.
…f A + 2**160 is X." test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the EXTCODEHASH operation from Constantinople.
The tests from the EIP around accounts that are created/destroyed haven't been implemented (tests 5 onwards) - firstly the cases in the current version of the EIP describe the scenario but not the expected outcome and secondly the presence or absence of an account is handled by MutableWorldState/WorldStateUpdater so actually separate to this change. They're good tests, but should be part of the Ethereum Reference Tests not reimplemented as overly-complex unit tests.