This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2129] Add GetNodeDataFromPeerTask #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Jan 18, 2019
| return Optional.empty(); | ||
| } | ||
|
|
||
| if (nodeData.stream().anyMatch(data -> !hashes.contains(Hash.hash(data)))) { |
There was a problem hiding this comment.
Might be nice to save this hash calculation, so we get back a mapping from hash -> data. Just saves us from duplicative hash calculations if we're already going to do that here.
|
Going to go ahead and merge since I need this :) |
|
Ok, since it's merged I'll leave it with you to save the hash calculation if it's useful to the calling code. It should be pretty straight-forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds GetNodeDataFromPeerTask that requests node data from a peer and matches up the results.
Fixed Issue(s)
NC-2129