This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[BUG] remove 127.0.0.1 from default hosts configs #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
approved these changes
Feb 27, 2019
|
after discussion 127.0.0.1 is safe as a whitelisted host |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in PR #974 it added 127.0.0.1 to the host whitelist to make tests work under more environments. Adding this to the whitelist opens up a security vulnerability. This reverts that then changes the default setup for hosts to use the localhost loopback name.