Support ethermint #150
Support ethermint #150
Conversation
yihuang
force-pushed
the
ethermint
branch
2 times, most recently
from
169f9e0 to
3414e9f
Compare
levicook
requested review from
levicook
and removed request for
jtremback and
jkilpatr
|
working my way through this one today; fyi |
| let hd_path = args | ||
| .flag_hd_wallet_path | ||
| .as_deref() | ||
| .unwrap_or("m/44'/118'/0'/0/0"); |
There was a problem hiding this comment.
Let's use DEFAULT_HD_PATH here.
orchestrator/client/src/main.rs
Outdated
| let hd_path = args | ||
| .flag_hd_wallet_path | ||
| .as_deref() | ||
| .unwrap_or("m/44'/118'/0'/0/0"); |
There was a problem hiding this comment.
done, moved DEFAULT_HD_PATH to cosmos_gravity::crypto::.
orchestrator/Cargo.toml
Outdated
| @@ -13,3 +13,5 @@ members = [ | |||
| "register_delegate_keys", | |||
| "gorc", | |||
| ] | |||
| [patch.crates-io] | |||
| deep_space = { git = "https://github.com/yihuang/deep_space/", branch = "ethermint" } | |||
There was a problem hiding this comment.
Will this be merged into deep_space soon? Would prefer to avoid the external dependency
There was a problem hiding this comment.
@yihuang I am going to try and merge your changes to deep space in with the iqlusioninc deep space changes so we can just depend on that upstream repo.
There was a problem hiding this comment.
@yihuang I am going to try and merge your changes to deep space in with the iqlusioninc deep space changes so we can just depend on that upstream repo.
how's that going? 😄
| #[cfg(not(feature = "ethermint"))] | ||
| pub const DEFAULT_HD_PATH: &str = "m/44'/118'/0'/0/0"; | ||
|
|
||
| /// PriateKey wraps cosmos private key, switch between cosmos and ethermint behavior according to compile feature. |
|
fixed conflicts and squashed. |
yihuang
force-pushed
the
ethermint
branch
2 times, most recently
from
81036d9 to
bdc4a80
Compare
- patch deep_space with ethermint fork - add a PrivateKey which switch to ethermint when ethermint feature is turn on - change default hd_path if ethermint feature turn on change to crypto-org-chain repo fix test_runner build
|
can be close crypto-org-chain#31 |
Closes #145
Add a cargo feature to switch to ethermint mode:
deep_space PR: iqlusioninc/deep_space#1