Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ethermint mode with features #359

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Support ethermint mode with features #359

merged 2 commits into from
Feb 22, 2022

Conversation

thomas-nguy
Copy link
Contributor

@thomas-nguy thomas-nguy commented Feb 9, 2022 •
edited
Loading

  • update deep_space with ethermint feature
  • add a PrivateKey which switch to ethermint when ethermint feature is turn on
  • change default hd_path if ethermint feature turn on

To build with ethermint feature run :
cargo build --features ethermint

yihuang
yihuang approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same patch as this one: crypto-org-chain#31, which is verified in cronos's integration tests.

@hannydevelop hannydevelop requested review from EricBolten and removed request for hannydevelop February 18, 2022 12:32
@jackzampolin
Copy link
Contributor

jackzampolin commented Feb 18, 2022 •
edited
Loading

So why wouldn't we use IBC instead of gravity bridge? Also we have a separate deep space implementation that has diverged from upstream that would like to continue to use.

EricBolten
EricBolten reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question regarding patching.

orchestrator/Cargo.toml Show resolved Hide resolved
@yihuang @thomas-nguy
Support ethermint mode with features
adb469d 
- update deep_space with ethermint feature
- add a PrivateKey which switch to ethermint when ethermint feature is turn on
- change default hd_path if ethermint feature turn on
@thomas-nguy thomas-nguy force-pushed the thomas/add-ethermint-support branch from d3ae46d to adb469d Compare February 22, 2022 08:02
@thomas-nguy thomas-nguy force-pushed the thomas/add-ethermint-support branch from 703577e to d438d94 Compare February 22, 2022 08:29
@thomas-nguy
Copy link
Contributor Author

@jackzampolin @EricBolten I have reverted the previous cargo.lock change and just updated with minimal changes. It should be more manageable to review

thanks @yihuang for the effort

@cbrit
Copy link
Member

cbrit commented Feb 22, 2022

So why wouldn't we use IBC instead of gravity bridge? Also we have a separate deep space implementation that has diverged from upstream that would like to continue to use.

@thomas-nguy wanted to make sure you saw this question from Jack! I don't think we want to move back to the deep_space in crates.io at this time.

@zmanian zmanian merged commit 9bf8d5d into PeggyJV:main Feb 22, 2022
@thomas-nguy thomas-nguy mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

@EricBolten EricBolten EricBolten left review comments

@zmanian zmanian zmanian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thomas-nguy @jackzampolin @cbrit @zmanian @yihuang @EricBolten