Add query endpoint for subcribers who are validators, simplify AddPublisher proposal #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EricBolten
commented
Feb 3, 2024
•
EricBolten
commented
- Run one query to return all subscribers who are also validators
- Allow governance to update an existing publisher
EricBolten
requested review from
jackzampolin,
kkennis and
mvid
as code owners
cbrit
approved these changes
Feb 3, 2024
| func (k Keeper) GetValidatorSubscribers(ctx sdk.Context) (subscribers []*types.Subscriber) { | ||
| allSubscribers := k.GetSubscribers(ctx) | ||
| for _, subscriber := range allSubscribers { | ||
| subscriberAddress, err := sdk.AccAddressFromBech32(subscriber.Address) |
There was a problem hiding this comment.
I have ptsd from this method now. As long as we're confident it's impossible to get a non-somm prefixed address through AddSubcriber this is fine
There was a problem hiding this comment.
changing it to log an error and continue instead for now
EricBolten
changed the title
|
Confirmed with @cbrit on Telegram. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.