Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] FreeLists form is deprecated #412

Closed
1 task done
talha131 opened this issue Jul 1, 2019 · 3 comments
Closed
1 task done

[BUG] FreeLists form is deprecated #412

talha131 opened this issue Jul 1, 2019 · 3 comments
Assignees
@ashwinvis
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Milestone
2019 - Q3

Comments

@talha131
Copy link
Member

talha131 commented Jul 1, 2019

Mandatory Step

  • I am using latest production release of Elegant

Description

Describe the bug

Using FreeLists subscription form does not work. Instead it redirects user to a new page which says the form has been deprecated.

Screenshots

https://www.freelists.org/cgi-bin/subscription.cgi
@talha131 talha131 added the bug Well, it shouldn’t be doing that. Let’s fix it! label Jul 1, 2019
@talha131 talha131 added this to the 2019 - Q3 milestone Jul 1, 2019
@talha131
Copy link
Member Author

talha131 commented Jul 1, 2019

@ashwinvis you added this feature in 2bbfb0f.

Let me know what can we do to fix it. New form has a Captcha field.

Possible solutions

  1. Update the form code
  2. or Instead of form, have a link that takes user to the form hosted on FreeList website

talha131 added a commit that referenced this issue Jul 1, 2019
@talha131
docs(update): add warning that freelists form is not working
1269684 
re #412
@ashwinvis
Copy link
Contributor

Thanks for checking. I wasn't aware of it. I don't think option 1 is feasible now according to the docs:

this process is deprecated and will be sunset and replaced with something else in the future.

We can have something very simple like like:

<form action=""https://www.freelists.org/list/{{ FREELISTS_NAME }}">
    <input type="submit" value="Subscribe" />
</form>

Ref: https://stackoverflow.com/questions/2906582/how-to-create-an-html-button-that-acts-like-a-link

@talha131
Copy link
Member Author

talha131 commented Jul 1, 2019

Cool. Can you open a PR for it?

ashwinvis added a commit to ashwinvis/pelican-elegant that referenced this issue Jul 23, 2019
@ashwinvis
fix(freelists): Simple button for freelists
e77c6af 
Fixes deprecation reported in Pelican-Elegant#412
@ashwinvis ashwinvis mentioned this issue Jul 23, 2019
Closed
5 tasks
talha131 pushed a commit that referenced this issue Jul 26, 2019
@ashwinvis @talha131
fix(freelists): replace deprecated subscription form with button
9bfe3c1 
Fixes deprecation reported in #412
talha131 pushed a commit that referenced this issue Jul 30, 2019
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
48f3964 
# [3.2.0](V3.1.0...V3.2.0) (2019-07-30)

### Bug Fixes

* **freelists:** open FreeLists subscription form in a new tab ([f81657c](f81657c))
* **freelists:** replace deprecated subscription form with button ([9bfe3c1](9bfe3c1)), closes [#412](#412)
* **freelists:** rm unused include ([27f0831](27f0831))

### Features

* **comments:** reduce transition duration from 500 to 200 ([b86e13d](b86e13d))
* **favicon:** add 180x180 dimension shortcut icon support ([dd2ed24](dd2ed24))
* **filter:** add black list, white list feature for Disqus ([4887aec](4887aec))
* **filter:** add black list, white list feature for FreeLists ([2407cc8](2407cc8))
* **filter:** add black list, white list feature for Mailchimp ([b96122d](b96122d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashwinvis ashwinvis

Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Milestone
2019 - Q3
Development

No branches or pull requests
2 participants
@talha131 @ashwinvis