Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<meta> tags on frontpage #505

Closed
iranzo opened this issue Sep 6, 2019 · 7 comments
Closed

<meta> tags on frontpage #505

iranzo opened this issue Sep 6, 2019 · 7 comments
Assignees
@iranzo
Labels
pull request welcome Not a priority right now, but if you provide a pull request, we would merge it. released
Milestone
2020 - Q1

Comments

@iranzo
Copy link
Member

iranzo commented Sep 6, 2019 •
edited
Loading

Should we fill the opengraph protocol tags also on header?

meta keywords could be filled with all articles in website tags

meta description to be the 'about' text for website

authors to be filled with all website authors?
@talha131 talha131 added the pull request welcome Not a priority right now, but if you provide a pull request, we would merge it. label Jan 19, 2020
@talha131
Copy link
Member

@iranzo we should be using as many tags as possible.

Let me know which tags we can use in the header and other sections which you have pointed out.

@iranzo iranzo self-assigned this Jan 19, 2020
@iranzo
Copy link
Member Author

iranzo commented Jan 19, 2020 •
edited
Loading

meta description
meta property="og:image"
meta keywords=

I would fill keywords with all article keywords and for description, allow to use either a new variable if needed

og:image is used for twitter, linkedin for showing miniature of webpage, so would be one default for blog or favicon and use the 'featured_image' from #550 for articles that contain it

@talha131
Copy link
Member

Have a look, please, and let me know what I am missing.

  1. https://github.com/Pelican-Elegant/elegant/blob/master/templates/_includes/smo_metadata.html
  2. https://github.com/Pelican-Elegant/elegant/blob/master/templates/article.html#L19

To my understanding, we already have what you suggested.

@iranzo
Copy link
Member Author

iranzo commented Jan 20, 2020

2 only applies for 'articles', my reasoning was for 'front page' or main page of the site.
In this case, the description is filled from article.summary
For the image, we have that for articles when it has the featured image, but not for site (AFAIK)

@talha131
Copy link
Member

I see. Thanks a lot for your explanation.

In this case, we will have to define custom variables that the user can leverage.

Can you open up a PR for this?

@talha131 talha131 added this to the 2020 - Q1 milestone Jan 20, 2020
@iranzo
Copy link
Member Author

iranzo commented Jan 20, 2020

Of course, that was my idea :)

This was referenced Jan 20, 2020
Closed
Closed
talha131 added a commit that referenced this issue Jan 23, 2020
@talha131
fix(seo): regression introduced in PR #556
28bcb85 
fix #505
talha131 pushed a commit that referenced this issue Feb 3, 2020
@semantic-release-bot
chore(release): 5.2.0 [skip ci]
f57da89 
# [5.2.0](V5.1.0...V5.2.0) (2020-02-03)

### Bug Fixes

* regression introduced due to cache busting ([b953a38](b953a38))
* **archives:** at smaller screen layout does not make the best use of available space ([a289e9d](a289e9d))
* **syntax:** code blocks with line numbers do not have the correct border radius ([3a34a3e](3a34a3e))
* **syntax:** improve the font size and height of download button ([07595b3](07595b3))
* **typography:** fix font size and style of TOC ([2d597ab](2d597ab)), closes [#509](#509)
* Categories and Tags pages do not have space below the header ([d78f4e5](d78f4e5))
* remove invalid CSS rule ([368cb2c](368cb2c))
* use consistent color for border ([c85b7b8](c85b7b8))
* use darker color for the site name ([19f37ca](19f37ca))
* **article:** use loclate_date attribute instead of hardcoding the date format ([1da552c](1da552c)), closes [#552](#552)
* **bootstrap:** WIP. add Bootstrapv2.3.2 sources file to the project ([43ee8eb](43ee8eb)), closes [#429](#429)
* **seo:** regression introduced in PR [#556](#556) ([28bcb85](28bcb85)), closes [#505](#505)
* **typography:** about me and my projects heading is not on one line ([6a7989c](6a7989c))
* **typography:** font size of superscript number in categories and tags page ([d0a7162](d0a7162))
* **typography:** override Bootstrap base font ([f6a83a6](f6a83a6)), closes [#429](#429)
* **typography:** top menu bar does not have correct height ([d30ce82](d30ce82))
* **typography:** use consistent font and color for project list ([477a467](477a467))
* **typography:** use consistent font in the footer ([eeb0e30](eeb0e30))

### Features

* add support cache busting ([cde0dc5](cde0dc5))
* **categories:** change background color of uncollapsed Category ([6cc11b8](6cc11b8))
* **gallery:** add support for PhotoSwipe image gallery using raw HTML ([ad1bcea](ad1bcea)), closes [#567](#567)
* **js:** combine and minify all JS files into one to improve load speed ([f5047d4](f5047d4))
* **search:** improve search results page look ([73fa743](73fa743)), closes [#573](#573) [#275](#275)
* **search:** replace tipue_search with lunr.js ([9d60af1](9d60af1)), closes [#275](#275)
* **SEO:** Add header and documentation for Claiming Website on Yandex ([2bb691d](2bb691d))
* **SEO:** add SEO and SMO meta keywords in site's home page ([c5be0eb](c5be0eb))
* **sharing:** Enable customizing the sharing links ([f3e262f](f3e262f))
* **syntax:** add copy to clipboard button for every code snippet ([6f73317](6f73317)), closes [#574](#574) [#525](#525)
* **syntax:** add support for highlighting lines in code snippets ([ba2de8c](ba2de8c)), closes [#520](#520)
* **syntax:** add support for liquid_tags.include_code plugin ([0550a3a](0550a3a)), closes [#518](#518)
* **syntax:** use Gruvbox syntax highlighting theme ([0b50ab1](0b50ab1))
* **typography:** use consistent fonts ([8b7a8bd](8b7a8bd)), closes [#429](#429)
* **typography:** use consistent style for timestamps in tags, categories and archives pages ([a421dcd](a421dcd))
* **typography:** use dns-prefetch and preconnect to improve font load time ([e4bd582](e4bd582))
* **typography:** use responsive fonts ([39acdbf](39acdbf))
@talha131
Copy link
Member

talha131 commented Feb 3, 2020

🎉 This issue has been resolved in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iranzo iranzo

Labels
pull request welcome Not a priority right now, but if you provide a pull request, we would merge it. released
Milestone
2020 - Q1
Development

Successfully merging a pull request may close this issue.

Meta tags in frontpage iranzo/elegant
2 participants
@iranzo @talha131