(feat): Add JS suport for instagram gallery

[iranzo]

Prerequisites

• My Pull Request is filled against the next branch
• All commits in my Pull Request conform to Elegant Git commit Guidelines

Recommended Steps

• My patch adds a new feature, therefore I have also added a help article about it
• My patch changes Elegant behavior, therefore I have updated the help article to reflect this change
• My commits are signed

Description

This PR modifies article.html so that it can show instagram pictures or group of pictures as galleries via adding a new yaml preamble named 'instagram'

Example at: https://deploy-preview-560--pelicanelegant.netlify.com/how-to-use-galleriaio-plugin

[iranzo]

Related with #385

[talha131]

Thanks a lot for this PR. I have requested some changes from you.

[talha131]

Please rebase.

[iranzo]

ok

[talha131]

@iranzo Kindly fix the issues I have mentioned.

Next, this patch adds one more dependency to the jquery. We can use other JS frameworks that do not depend on jquery, like

1. https://photoswipe.com/
2. https://sachinchoolur.github.io/

Will you be able to replace galleriajs with photoswipe? If not then we both can work together on this feature. It ain't difficult. We can finish it in two days.

[iranzo]

@iranzo Kindly fix the issues I have mentioned.

Next, this patch adds one more dependency to the jquery. We can use other JS frameworks that do not depend on jquery, like

1. https://photoswipe.com/
2. https://sachinchoolur.github.io/

Will you be able to replace galleriajs with photoswipe? If not then we both can work together on this feature. It ain't difficult. We can finish it in two days.

All other things addressed.
2nd url doesn't load, for 1st one it looks nice, but to get this kind of automation (just instragram_id) I will need to check if it's possible and how.

If we get both supported, we can make something that is compatible with both so that end user can decide or us put default of our preferred one and deprecate the other (if we want to get this included asap)

[talha131]

2nd url doesn't load

Sorry. Here you go https://sachinchoolur.github.io/lightgallery.js/

If we get both supported, we can make something that is compatible with both so that end user can decide or us put default of our preferred one and deprecate the other (if we want to get this included asap)

Too much work. I say as we have already decided to drop jquery, we should only choose a solution that works without jquery.

but to get this kind of automation (just instragram_id) I will need to check if it's possible and how.

It won't be much difficult to refactor jquery code to plain JS and make it work with photoswipe. As I said, we can work together on this feature.

---

Meanwhile, do fix the issues in this PR that I have pointed out. Photoswipe change will be made on top of this PR.

[iranzo]

One concern on ligthtgallery:

Is listed as free and open source library and repo contains: https://github.com/sachinchoolur/lightgallery.js/blob/master/LICENSE.md so it should be ok for us to use it

[talha131]

Right. I noticed the license.

Can you please compare both the libraries and let me know which one you think is better suited for us?
Like development activity, community etc.

[iranzo]

Based on latest posts and amount of contributors, photoswipe seems the most maintained (lightgallery is 1 year back in time and 10 contribs vs 42 in photoswipe)

[talha131]

Ok so photoswipe it is.

Now, if you can do this task alone then please update the PR.
Else if you need my help then,

1. Resolve the issues I pointed out in the review
2. I will open a new branch so that we both can work together on it.

[iranzo]

@talha131 the ones about galleria.io are already in this PR and in the preview (together with admonition usage for the single-multiple)

[talha131]

Thank you @iranzo.

You can view my progress and changes here. #567

To make or add your changes open your PR against feat-image-gallery branch.

---

Closing this PR in favor of #567