Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated pelican Transport needs to be regenerated after configs #168

Closed
bbockelm opened this issue Oct 1, 2023 · 0 comments · Fixed by #183
Closed

Generated pelican Transport needs to be regenerated after configs #168

bbockelm opened this issue Oct 1, 2023 · 0 comments · Fixed by #183
Assignees
Labels
internal Internal code improvements, not user-facing
Milestone

Comments

@bbockelm
Copy link
Collaborator

bbockelm commented Oct 1, 2023

The transport can be changed as part of the configuration process. For example, it can:

  1. Disable the TLS validation
  2. Add a newly-generated CA to the configuration (see Origin self-test #167)

The way we do (1) currently is overwrite the TLS validation setting each time we get a pointer to the transport. That's not thread-safe -- and we don't want to recompute this each time.

Instead, move the GetTransport() to the configuration sub-module so we can lazily recreate the object each time the configuration (client or server) is run.

@bbockelm bbockelm added the internal Internal code improvements, not user-facing label Oct 1, 2023
@bbockelm bbockelm added this to the v7.2.0 milestone Oct 1, 2023
@joereuss12 joereuss12 linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal code improvements, not user-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants