Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pelican transport fixes and generated after configs #183

Conversation

joereuss12
Copy link
Contributor

Fixed an issue with common transports for some reason not getting correct value from defaults.yaml. Also addressed issue moving the common transports to the config sub-module and allowed initClient and initServer to recreate the common transport object. In addition, moved the TLSSkipVerify to only run when setupTransfer is called again (either first time GetTransfer() is called or initClient() or initServer() is called).

Fixed an issue with common transports for some reason not getting correct value from defaults.yaml. Also addressed issue moving the common transports to the config sub-module and allowed initClient and initServer to recreate the common transport object. In addition, moved the TLSSkipVerify to only run when setupTransfer is called again (either first time `GetTransfer()` is called or `initClient()` or `initServer()` is called).
@joereuss12 joereuss12 added this to the v7.2.0 milestone Oct 4, 2023
@joereuss12 joereuss12 linked an issue Oct 4, 2023 that may be closed by this pull request
@joereuss12 joereuss12 added bug Something isn't working internal Internal code improvements, not user-facing labels Oct 4, 2023
config/config.go Dismissed Show dismissed Hide dismissed
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhiemstrawisc jhiemstrawisc merged commit 40a681a into PelicanPlatform:main Oct 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Internal code improvements, not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated pelican Transport needs to be regenerated after configs
2 participants