Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to ttlcache to make sure cache eviction works #330

Closed
haoming29 opened this issue Nov 6, 2023 · 0 comments · Fixed by #416
Closed

Add unit tests to ttlcache to make sure cache eviction works #330

haoming29 opened this issue Nov 6, 2023 · 0 comments · Fixed by #416
Assignees
Labels
bug Something isn't working test Improvements to the test suite
Milestone

Comments

@haoming29
Copy link
Contributor

I'm not sure if we want the ttlcache to automatically evict expired cache entry but if we do, according to the documentation here, we seem not to call go cache.Start() anywhere in our code and we don't seem to call cache.DeleteExpired() periodically which are the only two ways to make the eviction work. So I propose we add some unit tests to at least one instance of ttlcache we used to ensure the eviction work.

@haoming29 haoming29 added the test Improvements to the test suite label Nov 6, 2023
@bbockelm bbockelm added this to the v7.4.0 milestone Nov 7, 2023
@haoming29 haoming29 self-assigned this Nov 8, 2023
@haoming29 haoming29 added the bug Something isn't working label Nov 28, 2023
@haoming29 haoming29 modified the milestones: v7.4.0, v7.3.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Improvements to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants