Ensure TTL caches evict expired item #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
force-pushed
the
test-cache-eviction
branch
from
d2e419a to
aa786b2
Compare
jhiemstrawisc
requested changes
Nov 29, 2023
Improve header comment to be more clear More comments
haoming29
force-pushed
the
test-cache-eviction
branch
from
39652d0 to
a143e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330
The added unit tests to director's
serverAdscache andnamespaceKeyscache suggest that expired cache item won't be evicted with existing code, so this PR addedcache.Start()to all TTL cache instances to ensure they work as expected.The part I'm not sure about is whether we should call
cache.Stop()at the shutdown of the program. I calledStop()for now but I don't know if this is redundant or not.