Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ORM to registry #646

Closed
haoming29 opened this issue Jan 12, 2024 · 1 comment · Fixed by #804
Closed

Integrate ORM to registry #646

haoming29 opened this issue Jan 12, 2024 · 1 comment · Fixed by #804
Assignees
@haoming29
Labels
critical High priority for next release internal Internal code improvements, not user-facing registry Issue relating to the registry component
Milestone
v7.6.0

Comments

@haoming29
Copy link
Contributor

Currently we handle all the CRUD manually via SQL queries, but as the registry service grows in complexity, it's becoming harder to maintain this structure given potential schema evolution in #518 and #623. So we want to integrate an ORM package to automate various process and make our lives easier.

Looks like gorm is the most popular one, and it have a set of nice features like DB migration, flexible model definition, and a bunch of others.
@haoming29 haoming29 added the internal Internal code improvements, not user-facing label Jan 12, 2024
@haoming29 haoming29 self-assigned this Jan 12, 2024
@haoming29 haoming29 added this to the v7.5.0 milestone Jan 12, 2024
@haoming29 haoming29 added the registry Issue relating to the registry component label Jan 23, 2024
@haoming29 haoming29 modified the milestones: v7.5.0, v7.6.0 Jan 26, 2024
@haoming29 haoming29 added the critical High priority for next release label Feb 6, 2024
@haoming29
Copy link
Contributor Author

haoming29 commented Feb 9, 2024 •
edited
Loading

A (potentially) good migration tool to use: https://atlasgo.io/guides/migration-tools/golang-migrate
https://atlasgo.io/guides/orms/gorm

@haoming29 haoming29 mentioned this issue Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haoming29 haoming29

Labels
critical High priority for next release internal Internal code improvements, not user-facing registry Issue relating to the registry component
Projects
None yet
Milestone
v7.6.0
Development

Successfully merging a pull request may close this issue.

Integrate ORM and versioned DB migrations to registry haoming29/pelican
1 participant
@haoming29