Integrate ORM and versioned DB migrations to registry #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
critical
jhiemstrawisc
requested changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646
This PR introduced gorm, an ORM for interacting with registry sqlite database, and migrated raw SQL queries to use gorm queries
It also introduced goose, a DB migration tool for versioned schema migration. Although gorm has built-in
AutoMigrationfunction, it fails quickly with an existing database and it does not support versioned migration.It finally removed the conditional creation of
topologytable but rather create the table by default, and populate the value if it's in OSDF mode.The easiest way to test is to build and spin up your
registrywith-dflag and watch for the message at the beginning of the log:goose: successfully migrated database to version: 20240212194951